On Monday 15 October 2007 19:43:21 Ingo Molnar wrote:
>
> * Ingo Molnar <[email protected]> wrote:
>
> > find attached another config that reproduces the build failure above.
> >
> > i think the reason is this:
> >
> > CONFIG_SSB=m
> > CONFIG_USB_OHCI_HCD=y
> > CONFIG_USB_OHCI_HCD_SSB=y
>
> the patch below fixes this for me.
>
> Ingo
>
> ----------------------->
> Subject: usb: fix ssb_ohci_probe() build bug
> From: Ingo Molnar <[email protected]>
>
> fix ssb_ohci_probe() build bug:
>
> drivers/built-in.o: In function `ssb_ohci_probe':
> ohci-hcd.c:(.text+0xbff39): undefined reference to `ssb_device_enable'
> ohci-hcd.c:(.text+0xbff6f): undefined reference to `ssb_admatch_base'
> ohci-hcd.c:(.text+0xbff8b): undefined reference to `ssb_admatch_size'
> ohci-hcd.c:(.text+0xbffe5): undefined reference to `ssb_device_disable'
> [...]
>
> the reason was that this Kconfig combination was allowed:
>
> CONFIG_SSB=m
> CONFIG_USB_OHCI_HCD=y
> CONFIG_USB_OHCI_HCD_SSB=y
>
> the fix is to require a modular USB_OHCI_HCD build when SSB is modular.
>
> Signed-off-by: Ingo Molnar <[email protected]>
Acked-by: Michael Buesch <[email protected]>
Somebody of the USB folks apply this, please.
> ---
> drivers/usb/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/usb/host/Kconfig
> ===================================================================
> --- linux.orig/drivers/usb/host/Kconfig
> +++ linux/drivers/usb/host/Kconfig
> @@ -156,7 +156,7 @@ config USB_OHCI_HCD_PCI
>
> config USB_OHCI_HCD_SSB
> bool "OHCI support for Broadcom SSB OHCI core"
> - depends on USB_OHCI_HCD && SSB && EXPERIMENTAL
> + depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
> default n
> ---help---
> Support for the Sonics Silicon Backplane (SSB) attached
>
>
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
