Re: [patch] scsi: fix crash in gdth_timeout()

Linus Torvalds wrote:

On Mon, 15 Oct 2007, Ingo Molnar wrote:

A further problem is probably that the GDTH timer is not stopped by a
failed GDTH probe?

Indeed. Maybe this is a better fix?

That driver is pretty messy, and this should have been found ealier. James? Boaz?

FWIW, the gdth driver was "super-messy". With this latest SCSI pull, that severity has been successfully downgraded to "messy" :)

IMO some easy-to-fix breakage was inevitable with such a large volume of fundamental changes.

Honestly, the driver is probably rarely run by people that lack the hardware, I bet...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] scsi: fix crash in gdth_timeout()
    • From: Boaz Harrosh <[email protected]>

• References:
  • [patch] scsi: fix crash in gdth_timeout()
    • From: Ingo Molnar <[email protected]>
  • Re: [patch] scsi: fix crash in gdth_timeout()
    • From: Linus Torvalds <[email protected]>

• Prev by Date: Re: [Rt2400-devel] [PATCH] jiffies_round -> jiffies_round_relative conversion - rt2x00
• Next by Date: Re: What still uses the block layer?
• Previous by thread: Re: [patch] scsi: fix crash in gdth_timeout()
• Next by thread: Re: [patch] scsi: fix crash in gdth_timeout()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]