Avi Kivity wrote: > Ingo Molnar wrote: >> * Avi Kivity <[email protected]> wrote: >> >> >>> This bit can go; for the external module I can add it back in >>> external-module-compat.h. No need to pollute mainline with backward >>> compatibility stuff. >>> >> >> hm: >> >> static inline void kvm_guest_enter(void) >> { >> current->flags |= PF_VCPU; >> } >> >> static inline void kvm_guest_exit(void) >> { >> } >> >> shouldnt PF_VCPU be cleared in kvm_guest_exit()? >> > > IIRC the accounting code clears it, but yes, it may not have been called > at all, so clearing it here is needed. > No, It must not be cleared here because we can't enter in the accounting code between kvm_guest_enter(void) and kvm_guest_exit(void). This is why the accounting code clears it. I put a kvm_guest_exit() only for symmetry. Laurent -- ---------------- [email protected] ----------------- "Given enough eyeballs, all bugs are shallow" E. S. Raymond
Attachment:
signature.asc
Description: OpenPGP digital signature
- Follow-Ups:
- Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- From: Christian Borntraeger <[email protected]>
- Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- From: Avi Kivity <[email protected]>
- Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- References:
- Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- From: Ingo Molnar <[email protected]>
- Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- From: Avi Kivity <[email protected]>
- Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- From: Ingo Molnar <[email protected]>
- Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- From: Avi Kivity <[email protected]>
- Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- Prev by Date: Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting
- Next by Date: Re: [bug] usb build failure, latest -git
- Previous by thread: Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- Next by thread: Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.
- Index(es):
 |