Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

[Christian Borntraeger <borntraeger@de.ibm.com>]

Am Montag, 10. September 2007 schrieb Laurent Vivier:
> The aim of these four patches is to introduce Virtual Machine time accounting.

I would move this line
       if (p->flags & PF_VCPU) {
               account_guest_time(p, cputime);
------>                p->flags &= ~PF_VCPU;  <---------
               return;
       }
into kvm_guest_exit. Otherwise a guest that is running very long in 
guest context would only get the first tick accounted as guest time, no?

Besides that, this looks good and should work for kvm on s390 as well. 
Thanks Laurent.

Christian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/