[PATCH 27/75] dmi-id: Possible cleanup

From: Jean Delvare <[email protected]>

The DEFINE_DMI_ATTR macro has a single user left so we can expand it
for slightly shorter/simpler code.

Signed-off-by: Jean Delvare <[email protected]>
Acked-by: Lennart Poettering <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
 drivers/firmware/dmi-id.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c
index a7bd87d..b6e1eb7 100644
--- a/drivers/firmware/dmi-id.c
+++ b/drivers/firmware/dmi-id.c
@@ -20,10 +20,6 @@ struct dmi_device_attribute{
 #define to_dmi_dev_attr(_dev_attr) \
 	container_of(_dev_attr, struct dmi_device_attribute, dev_attr)
 
-#define DEFINE_DMI_ATTR(_name, _mode, _show)		\
-static struct device_attribute sys_dmi_##_name##_attr =	\
-	__ATTR(_name, _mode, _show, NULL);
-
 static ssize_t sys_dmi_field_show(struct device *dev,
 				  struct device_attribute *attr,
 				  char *page)
@@ -135,7 +131,8 @@ static ssize_t sys_dmi_modalias_show(struct device *dev,
 	return r+1;
 }
 
-DEFINE_DMI_ATTR(modalias, 0444, sys_dmi_modalias_show);
+static struct device_attribute sys_dmi_modalias_attr =
+	__ATTR(modalias, 0444, sys_dmi_modalias_show, NULL);
 
 static struct attribute *sys_dmi_attributes[DMI_STRING_MAX+2];
 
-- 
1.5.3.4

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 28/75] Convert from class_device to device for drivers/video
    • From: Greg Kroah-Hartman <[email protected]>

• References:
  • [PATCH 01/75] platform: prefix MODALIAS with "platform:"
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 02/75] HOWTO: update ja_JP/HOWTO with latest changes
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 03/75] Driver core: make sysfs uevent-attributes static
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 04/75] Driver core: change add_uevent_var to use a struct
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 05/75] Driver core: add CONFIG_UEVENT_HELPER_PATH
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 06/75] Driver core: remove subsys_set_kset
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 07/75] Driver core: remove kset_set_kset_s
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 08/75] Driver core: remove subsys_put()
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 09/75] Driver core: remove subsys_get()
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 10/75] Driver core: remove put_bus()
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 11/75] Driver core: remove get_bus()
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 12/75] kobjects: fix up improper use of the kobject name field
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 13/75] cdev: remove unneeded setting of cdev names
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 14/75] Drivers: clean up direct setting of the name of a kset
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 15/75] kobject: remove the static array for the name
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 16/75] Driver core: clean up removed functions from the documentation
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 17/75] debugfs: helper for decimal challenged
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 18/75] sysfs/file.c - use mutex instead of semaphore
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 19/75] sysfs: cleanup semaphore.h
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 20/75] sysfs: Remove first pass at shadow directory support
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 21/75] sysfs: cosmetic changes in sysfs_lookup()
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 22/75] sysfs: simplify sysfs_rename_dir()
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 23/75] sysfs: make sysfs_add/remove_one() call link/unlink_sibling() implictly
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 24/75] sysfs: make sysfs_add_one() automatically check for duplicate entry
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 25/75] sysfs: make sysfs_addrm_finish() return void
    • From: Greg Kroah-Hartman <[email protected]>
  • [PATCH 26/75] dmi-id: Use dynamic sysfs attributes
    • From: Greg Kroah-Hartman <[email protected]>

• Prev by Date: [PATCH 26/75] dmi-id: Use dynamic sysfs attributes
• Next by Date: [PATCH 28/75] Convert from class_device to device for drivers/video
• Previous by thread: [PATCH 26/75] dmi-id: Use dynamic sysfs attributes
• Next by thread: [PATCH 28/75] Convert from class_device to device for drivers/video
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]