On 10/8/07, Stephen Hemminger <[email protected]> wrote:
> On Sun, 7 Oct 2007 16:50:49 -0500
> Rob Landley <[email protected]> wrote:
>
> > On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote:
> > > On 10/5/07, Rob Landley <[email protected]> wrote:
> > I made it about halfway through the patch and the only compile time filtering
> > I found was:
> >
> > --- a/drivers/md/md.c
> > +++ b/drivers/md/md.c
> > @@ -62,7 +62,10 @@
> > #define MdpMinorShift 6
> >
> > #define DEBUG 0
> > -#define dprintk(x...) ((void)(DEBUG && printk(x)))
> > +#define dprintk(x...)\
> > +if(DEBUG) {\
> > + printk(x);\
> > +}
> >
> > If you say it does, I'll take your word for it, but there's so much churn in
> > there I didn't find it before my interest ran out...
> >
>
> BTW that change might actually break code (dangling else problems).
> The original way was safer.
Yep, thanks. I think containing it in do {} while(0) should fix, though, no?
Vegard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
