On Thu, 4 Oct 2007 12:38:05 +0200 Jens Axboe <[email protected]> wrote: > On Thu, Oct 04 2007, Pierre Ossman wrote: > > > > Is that a yes or a no? You said that the ->page field was involved > > in > > It's a conditional yes, re-read it :-) > I didn't get the memo about what chained sg entries entail. > > list chaining, so does or doesn't it have to be initialized before a > > call to sg_init_one()? > > That's not the problem. It has to be initialized before calling > blk_rq_map_sg(). sg_init_one() will zero the entire sg entry, and that > breaks if that particular sg entry is part of a larger sg table AND > that sg entry happens to be the chain element. > Ok, then it shouldn't affect my world at least. Rgds Pierre PS. Did someone forget to do a review of all blk_rq_map_sg() callers before committing the chained list stuff? ;)
Attachment:
signature.asc
Description: PGP signature
- Follow-Ups:
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Jens Axboe <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- References:
- 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Don Mullis <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Andrew Morton <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Jens Axboe <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Pierre Ossman <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Jens Axboe <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Pierre Ossman <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Jens Axboe <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Pierre Ossman <[email protected]>
- Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- From: Jens Axboe <[email protected]>
- 2.6.23-rc8-mm2: OOPS in mmc on boot
- Prev by Date: Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- Next by Date: Re: 2.6.23-rc9 boot failure (megaraid?)
- Previous by thread: Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- Next by thread: Re: 2.6.23-rc8-mm2: OOPS in mmc on boot
- Index(es):