Re: [PATCH -mm -v3 1/2] i386/x86_64 boot: setup data

["H. Peter Anvin" <hpa@zytor.com>]

Huang, Ying wrote:
> Hi, Peter,
> 
> On Wed, 2007-09-19 at 09:04 -0700, H. Peter Anvin wrote:
>> Huang, Ying wrote:
>>> Known Issues:
>>>
>>> 1. Where is safe to place the linked list of setup_data?
>>> Because the length of the linked list of setup_data is variable, it
>>> can not be copied into BSS segment of kernel as that of "zero
>>> page". We must find a safe place for it, where it will not be
>>> overwritten by kernel during booting up. The i386 kernel will
>>> overwrite some pages after _end. The x86_64 kernel will overwrite some
>>> pages from 0x1000 on.
>>>
>> The latter is definitely not safe, since the space below 640K is the
>> documented place to put the command line (and presumably where the
>> bootloader would put other auxilliary chunks.)
>>
>> I'll try to do a full review of this later today.  Haven't had time yet
>> to look at this anything than but piecemeal.
> 
> Do you think this patch and the 32-bit boot protocol patch are ready to
> merge for -mm? If not, I can revise them.
> 

Sorry, haven't had a chance to look at it in proper detail yet, mostly
due to debugging, but one thing I'd like to see is both the boot_params
structure as well as all the chained information pointers exported into
sysfs.  The experience with the x86 setup code has shown that it would
help immensely with debugging, not to mention being available to tools
like kexec.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/