Re: [patch 1/2] Enable link power management for ata drivers

On Tue, 25 Sep 2007 01:12:32 +0200
roel <[email protected]> wrote:

> >  #define ata_id_cdb_intr(id)	(((id)[0] & 0x60) == 0x20)
> > +#define ata_id_has_hipm(id)	\
> > +	( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \
> > +	  ((id)[76] & (1 << 9)) )
> 		^
> 		|
> are you sure this
> should be 76?

Yes.

> 
> we can also change the first statement a bit:
> 	(!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \
> 
> 
> > +#define ata_id_has_dipm(id)	\
> > +	( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \
> 
> and:
> 	(!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \

I feel this is equivalent functionality and not as readable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/2] Enable link power management for ata drivers
    • From: Jeff Garzik <[email protected]>

• References:
  • [patch 1/2] Enable link power management for ata drivers
    • From: Kristen Carlson Accardi <[email protected]>
  • Re: [patch 1/2] Enable link power management for ata drivers
    • From: roel <[email protected]>

• Prev by Date: Re: [PATCH 1/4] module: implement module_inhibit_unload()
• Next by Date: Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3
• Previous by thread: Re: [patch 1/2] Enable link power management for ata drivers
• Next by thread: Re: [patch 1/2] Enable link power management for ata drivers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]