Re: [git] CFS-devel, group scheduler, fixes

On Mon, 24 Sep 2007 12:10:09 +0200 Mike Galbraith <[email protected]> wrote:


> @@ -117,7 +117,7 @@ static inline struct task_struct *task_o
>  static inline u64
>  max_vruntime(u64 min_vruntime, u64 vruntime)
>  {
> -	if ((vruntime > min_vruntime) ||
> +	if (((s64)vruntime > (s64)min_vruntime) ||
>  	    (min_vruntime > (1ULL << 61) && vruntime < (1ULL << 50)))
>  		min_vruntime = vruntime;
>  

how about something like:

 s64 delta = (s64)(vruntime - min_vruntime);
 if (delta > 0)
  min_vruntime += delta;

That would rid us of most of the funny conditionals there.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>

• References:
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: dimm <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Ingo Molnar <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Tong Li <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Tong Li <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Ingo Molnar <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Tong Li <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Tong Li <[email protected]>
  • Re: [git] CFS-devel, group scheduler, fixes
    • From: Mike Galbraith <[email protected]>

• Prev by Date: Re: [PATCH 3/3] debloat aic7xxx and aic79xx drivers
• Next by Date: Re: 2.6.22.7 autoconf.h is screwed up
• Previous by thread: Re: [git] CFS-devel, group scheduler, fixes
• Next by thread: Re: [git] CFS-devel, group scheduler, fixes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]