On Tue, 2007-09-18 at 10:04 +0100, Christoph Hellwig wrote: > On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote: > > Here is the incremental small cleanup patch. > > > > Remove kamlloc usages in jbd/jbd2 and consistently use jbd_kmalloc/jbd2_malloc. > > Shouldn't we kill jbd_kmalloc instead? > It seems useful to me to keep jbd_kmalloc/jbd_free. They are central places to handle memory (de)allocation(<page size) via kmalloc/kfree, so in the future if we need to change memory allocation in jbd(e.g. not using kmalloc or using different flag), we don't need to touch every place in the jbd code calling jbd_kmalloc. Regards, Mingming - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] JBD slab cleanups
- From: Dave Kleikamp <[email protected]>
- Re: [PATCH] JBD slab cleanups
- References:
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Lameter <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Hellwig <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Lameter <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Hellwig <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Lameter <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- From: Christoph Hellwig <[email protected]>
- [PATCH] JBD slab cleanups
- From: Mingming Cao <[email protected]>
- Re: [PATCH] JBD slab cleanups
- From: Mingming Cao <[email protected]>
- Re: [PATCH] JBD slab cleanups
- From: Badari Pulavarty <[email protected]>
- Re: [PATCH] JBD slab cleanups
- From: Mingming Cao <[email protected]>
- Re: [PATCH] JBD slab cleanups
- From: Christoph Hellwig <[email protected]>
- Re: [RFC 1/2] JBD: slab management support for large block(>8k)
- Prev by Date: [PATCH 1/2][resend] gpio_keys: add gpio_to_irq return code check
- Next by Date: Re: 2.6.23-rc6-mm1 -- drivers/kvm/ioapic.c: In function ‘ioapic_deliver’: error: ‘dest_LowestPrio’ undeclared (first use in this function)
- Previous by thread: Re: [PATCH] JBD slab cleanups
- Next by thread: Re: [PATCH] JBD slab cleanups
- Index(es):
 |