Re: [PATCH] powerpc: Avoid pointless WARN_ON(irqs_disabled()) from panic codepath


On Tue, 18 Sep 2007, Satyam Sharma wrote:
> 
> > ------------[ cut here ]------------
> > Badness at arch/powerpc/kernel/smp.c:202
> 
> comes when smp_call_function_map() has been called with irqs disabled,
> which is illegal. However, there is a special case, the panic() codepath,
> when we do not want to warn about this -- warning at that time is pointless
> anyway, and only serves to scroll away the *real* cause of the panic and
> distracts from the real bug.

BTW arch/ppc/ has same issue, but that's gonna be removed by next year
anyways, so I think there's no point making a patch for that (?)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [BUG][2.6.23-rc6] Badness at arch/powerpc/kernel/smp.c:202
  - From: Kamalesh Babulal <[email protected]>
- Re: [BUG][2.6.23-rc6] Badness at arch/powerpc/kernel/smp.c:202
  - From: "Satyam Sharma" <[email protected]>
- [PATCH] powerpc: Avoid pointless WARN_ON(irqs_disabled()) from panic codepath
  - From: Satyam Sharma <[email protected]>

Prev by Date: Re: [PATCH 2/3] Consolidate host virtualization support under Virtualization menu
Next by Date: Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks
Previous by thread: [PATCH] powerpc: Avoid pointless WARN_ON(irqs_disabled()) from panic codepath
Next by thread: Re: [PATCH] powerpc: Avoid pointless WARN_ON(irqs_disabled()) from panic codepath
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]