Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page

On Mon, Sep 10, 2007 at 09:46:46PM +0200, Ingo Oeser wrote:
>
> What about using max() for this to make your intention obvious?
> 
> static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len)
> {
> 	u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK); 
> 	return max(start, end_page);
> }

Yes that looks sane.  Could you please send a patch?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- [PATCH] crypto: cleanup: Use max() in blkcipher_get_spot() to state the intention.
  - From: Ingo Oeser <[email protected]>

References:
- [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
  - From: Bob Gilligan <[email protected]>
- Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
  - From: Herbert Xu <[email protected]>
- Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
  - From: Herbert Xu <[email protected]>
- Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
  - From: Ingo Oeser <[email protected]>

Prev by Date: Re: Socket owner problem?
Next by Date: Re: [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t
Previous by thread: Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
Next by thread: [PATCH] crypto: cleanup: Use max() in blkcipher_get_spot() to state the intention.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]