Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page

On Sat, Sep 08, 2007 at 12:14:23PM +0800, Herbert Xu wrote:
> 
> [CRYPTO] blkcipher: Fix handling of kmalloc page straddling

As Bob correctly noted, I had the boolean test inverted.
Here is the correction:

[CRYPTO] blkcipher: Fix inverted test in blkcipher_get_spot

The previous patch had the conditional inverted.  This patch fixes it
so that we return the original position if it does not straddle a page.

Thanks to Bob Gilligan for spotting this.

Signed-off-by: Herbert Xu <[email protected]>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/crypto/blkcipher.c b/crypto/blkcipher.c
--- a/crypto/blkcipher.c
+++ b/crypto/blkcipher.c
@@ -65,7 +65,7 @@ static inline void blkcipher_unmap_dst(s
 static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len)
 {
 	u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK);
-	return start < end_page ? start : end_page;
+	return start > end_page ? start : end_page;
 }
 
 static inline unsigned int blkcipher_done_slow(struct crypto_blkcipher *tfm,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
    • From: Ingo Oeser <[email protected]>

• References:
  • [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
    • From: Bob Gilligan <[email protected]>
  • Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
    • From: Herbert Xu <[email protected]>

• Prev by Date: [PATCH][resend] Add suspend and resume to gpio_keys driver
• Next by Date: Re: [PATCH] PTR_ALIGN
• Previous by thread: Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
• Next by thread: Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]