Hi,
On Fri, 31 Aug 2007, Jesper Juhl wrote:
> In the iforce driver we currently get this warning
>
> drivers/input/joystick/iforce/iforce-packets.c: In function 'iforce_get_id_packet':
> drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable 'status'
>
> if CONFIG_JOYSTICK_IFORCE_USB is not defined.
>
> The warning is easy to avoid by simply moving the variable inside
> the only case in the switch that actually use it.
>
>
> Signed-off-by: Jesper Juhl <[email protected]>
> ---
>
> diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c
> index 3154ccd..48d4a86 100644
> --- a/drivers/input/joystick/iforce/iforce-packets.c
> +++ b/drivers/input/joystick/iforce/iforce-packets.c
> @@ -246,13 +246,12 @@ void iforce_process_packet(struct iforce *iforce, u16 cmd, unsigned char *data)
>
> int iforce_get_id_packet(struct iforce *iforce, char *packet)
> {
> - int status;
> -
> switch (iforce->bus) {
>
> case IFORCE_USB:
> -
> #ifdef CONFIG_JOYSTICK_IFORCE_USB
> + int status;
> +
> iforce->cr.bRequest = packet[0];
> iforce->ctrl->dev = iforce->usbdev;
Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y?
[ I didn't know mixing code and declarations (not at top of statement
block) was accepted style in the kernel ... ]
IMHO either you should at least wrap that case inside a {} of its
own (so that the int status; is at top of a statement block), or else,
preferably, just add "__maybe_unused" to the first declaration that you
removed just now.
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
