[PATCH] Fix out-by-one error in traps.c

We don't care if ebp is on the stack, we care about ebp + 4.  Without
this, lguest (with CONFIG_DEBUG_LOCKDEP) can touch a page unmapped by
CONFIG_DEBUG_PAGEALLOC.

Signed-off-by: Rusty Russell <[email protected]>

diff -r b0b1ab8ecf48 arch/i386/kernel/traps.c
--- a/arch/i386/kernel/traps.c	Fri Aug 31 03:25:06 2007 +1000
+++ b/arch/i386/kernel/traps.c	Fri Aug 31 07:57:35 2007 +1000
@@ -100,7 +100,7 @@ print_context_stack(struct thread_info *tinfo,
 	unsigned long addr;
 
 #ifdef	CONFIG_FRAME_POINTER
-	while (valid_stack_ptr(tinfo, (void *)ebp)) {
+	while (valid_stack_ptr(tinfo, (void *)ebp + 4)) {
 		unsigned long new_ebp;
 		addr = *(unsigned long *)(ebp + 4);
 		ops->address(data, addr);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix out-by-one error in traps.c
    • From: Linus Torvalds <[email protected]>

• References:
  • 2.6.23-rc3-mm1
    • From: Andrew Morton <[email protected]>
  • [-mm patch] enforce noreplace-smp in alternative_instructions()
    • From: Frederik Deweerdt <[email protected]>
  • Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
    • From: Andrew Morton <[email protected]>
  • Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
    • From: Frederik Deweerdt <[email protected]>
  • Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
    • From: Jeremy Fitzhardinge <[email protected]>
  • Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
    • From: Frederik Deweerdt <[email protected]>
  • Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
    • From: Rusty Russell <[email protected]>
  • Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
    • From: Frederik Deweerdt <[email protected]>
  • Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
    • From: Frederik Deweerdt <[email protected]>
  • [PATCH] Fix lguest page-pinning logic ("lguest: bad stack page 0xc057a000")
    • From: Rusty Russell <[email protected]>
  • Re: [PATCH] Fix lguest page-pinning logic ("lguest: bad stack page 0xc057a000")
    • From: Frederik Deweerdt <[email protected]>

• Prev by Date: Re: [PATCH] Fix lguest page-pinning logic ("lguest: bad stack page 0xc057a000")
• Next by Date: Re: [PATCH] input: Silence 'unused variable' warning in iforce joystick driver
• Previous by thread: Re: [PATCH] Fix lguest page-pinning logic ("lguest: bad stack page 0xc057a000")
• Next by thread: Re: [PATCH] Fix out-by-one error in traps.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]