On Mon, 27 Aug 2007 17:43:33 EDT, "J. Bruce Fields" said: > Looks like a reasonable idea to me, thanks! Any objection to just > calling it "svc_printk" instead of "svc_printkerr"? > > I also wonder whether these shouldn't all be dprintk's instead of > printk's. One misbehaving client could create a lot of noise in the > logs. I shouldn't have to rebuild my kernel with debugging enabled just to see who is throwing trash at my machine. printk(KERN_INFO maybe and/or using a printk_ratelimit.
Attachment:
pgp4e2v38CFcV.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH] Add source address to sunrpc svc errors
- From: Peter Staubach <[email protected]>
- Re: [PATCH] Add source address to sunrpc svc errors
- From: "J. Bruce Fields" <[email protected]>
- Re: [PATCH] Add source address to sunrpc svc errors
- References:
- [PATCH] Add source address to sunrpc svc errors
- From: "Dr. David Alan Gilbert" <[email protected]>
- Re: [PATCH] Add source address to sunrpc svc errors
- From: Randy Dunlap <[email protected]>
- Re: [PATCH] Add source address to sunrpc svc errors
- From: "Dr. David Alan Gilbert" <[email protected]>
- Re: [PATCH] Add source address to sunrpc svc errors
- From: "J. Bruce Fields" <[email protected]>
- [PATCH] Add source address to sunrpc svc errors
- Prev by Date: [PATCH] netlink: use container_of instead
- Next by Date: [RFC] 9p Virtualization Transports
- Previous by thread: Re: [PATCH] Add source address to sunrpc svc errors
- Next by thread: Re: [PATCH] Add source address to sunrpc svc errors
- Index(es):
 |