On Sun, 12 Aug 2007, Rene Herman wrote:
> > > /*
> > > * Maximum threshold is 125
> > > */
> > > threshold = min(125, threshold);
> > >
> > > as either the comment or the code is wrong and it seems it's the code.
> > > Added Andrew Morton to the CC for that.
> >
> > Yes, that's inconsistent. And looking at Christoph's df9ecaba it's unclear
> > whether the comment is wrong or the code is wrong. The code is wrong, I
> > expect.
?? What is wrong with the code? We want the threshold to stay below 125?
> On 08/12/2007 05:29 AM, Roland Dreier wrote:
>
> > What's the problem? That line sets threshold to the smaller of the current
> > value or 125, which is exactly what one would want to do if the
> > maximum value is 125. Just do a couple of examples: eg if threshold is
> > 100 going into that line, then the value is left alone; if threshold is
> > 150 then it gets set to 125; and that seems exactly correct.
Exactly.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
