> In that code we could just do a test on valp (i.e. data in struct > ctl_table). Or you could pass the struct pointer and subtract the array start > I just wanted something stupid and simple, so the -mm tree would not > be full of broken sysctls. Well I'd like you to not replace one pile of hard to clean up but easy to locate crap by smearing other hard to fix in one go crap over the kernel. > > At least to my eyes the code doesn't look much worse. But if you > want to do something better feel free. I'll add it to my todo list. But in the meantime I still NAK the change. I'll try and get a patch sorted but it'll be after the kernel summit for sure. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
- References:
- [PATCH] Remove CTL_UNNUMBERED
- From: Alexey Dobriyan <[email protected]>
- Re: [PATCH] Remove CTL_UNNUMBERED
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH] Remove CTL_UNNUMBERED
- From: Alexey Dobriyan <[email protected]>
- [PATCH 2/2] sysctl: remove CTL_UNNUMBERED
- From: Alexey Dobriyan <[email protected]>
- [PATCH 1/3] sysctl core: Stop using the unnecessary ctl_table typedef
- From: [email protected] (Eric W. Biederman)
- [PATCH 2/3] sysctl: Factor out sysctl_data.
- From: [email protected] (Eric W. Biederman)
- [PATCH 3/3] sysctl: Error on bad sysctl tables
- From: [email protected] (Eric W. Biederman)
- [PATCH 01/10] sysctl: Update sysctl_check_table
- From: [email protected] (Eric W. Biederman)
- [PATCH 02/10] sysct mqueue: Remove the binary sysctl numbers
- From: [email protected] (Eric W. Biederman)
- [PATCH 03/10] sysctl: Remove binary sysctl support where it clearly doesn't work.
- From: [email protected] (Eric W. Biederman)
- [PATCH 04/10] sysctl: Fix neighbour table sysctls.
- From: [email protected] (Eric W. Biederman)
- [PATCH 05/10] sysctl: ipv6 route flushing (kill binary path)
- From: [email protected] (Eric W. Biederman)
- [PATCH 06/10] sysctl: Remove broken sunrpc debug binary sysctls
- From: [email protected] (Eric W. Biederman)
- [PATCH 07/10] sysctl: x86_64 remove unnecessary binary paths.
- From: [email protected] (Eric W. Biederman)
- [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
- From: Alan Cox <[email protected]>
- Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
- From: [email protected] (Eric W. Biederman)
- [PATCH] Remove CTL_UNNUMBERED
- Prev by Date: Re: [PATCH 2/4] writeback: 3-queue based writeback schedule
- Next by Date: Re: 2.6.23-rc2-mm2
- Previous by thread: Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
- Next by thread: Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
- Index(es):
 |