Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls

On Thu, 09 Aug 2007 19:01:14 -0600
[email protected] (Eric W. Biederman) wrote:

> 
> The binary interface for the cdrom sysctls can't possilby work.
> So remove the binary sysctls and update the test for finding
> out which sysctl table entry we are dealy with to use the procname
> and not the ctl_name (which I am removing).

NAK

I've no problem with the basic idea of removing the names from user
space, but you've just demonstrated with the patch below that it causes
some quite revolting changes for the bad in code which previously was
nicely done switch statements and is now a nest of string compares and
inline code.

There are very good reasons to have a cookie in the sysctl entry for
internal use and which is private to the subsystem using the sysctl (ie
not for sysctl() use and not neccessarily unique).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH] Remove CTL_UNNUMBERED
    • From: Alexey Dobriyan <[email protected]>
  • Re: [PATCH] Remove CTL_UNNUMBERED
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH] Remove CTL_UNNUMBERED
    • From: Alexey Dobriyan <[email protected]>
  • [PATCH 2/2] sysctl: remove CTL_UNNUMBERED
    • From: Alexey Dobriyan <[email protected]>
  • [PATCH 1/3] sysctl core: Stop using the unnecessary ctl_table typedef
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 2/3] sysctl: Factor out sysctl_data.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 3/3] sysctl: Error on bad sysctl tables
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 01/10] sysctl: Update sysctl_check_table
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 02/10] sysct mqueue: Remove the binary sysctl numbers
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 03/10] sysctl: Remove binary sysctl support where it clearly doesn't work.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 04/10] sysctl: Fix neighbour table sysctls.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 05/10] sysctl: ipv6 route flushing (kill binary path)
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 06/10] sysctl: Remove broken sunrpc debug binary sysctls
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 07/10] sysctl: x86_64 remove unnecessary binary paths.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: [PATCH] Fix OOPS in show_uevent()
• Next by Date: Re: 2.6.23-rc2-mm1 -- drivers/dma/ioat_dca.c:177: error: implicit declaration of function ___cpu_physical_id___
• Previous by thread: [PATCH 10/10] sysctl: Remove the binary interface for aio-nr, aio-max-nr, acpi_video_flags
• Next by thread: Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]