Glauber de Oliveira Costa wrote:
>>> +/*
>>> + * integers must be use with care here. They can break the PARAVIRT_PATCH(x)
>>> + * macro, that divides the offset in the structure by 8, to get a number
>>> + * associated with the hook. Dividing by four would be a solution, but it
>>> + * would limit the future growth of the structure if needed.
>>>
>>>
>> Why not just stick them at the end of the structure?
>>
>
> Does it really matter?
>
Well, yes, if alignment is an issue.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 25/25] [PATCH] add paravirtualization support for x86_64
- From: "Glauber de Oliveira Costa" <[email protected]>
- Re: [PATCH 25/25] [PATCH] add paravirtualization support for x86_64
- References:
- Introducing paravirt_ops for x86_64
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 17/25] [PATCH] turn page operations into native versions
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 20/25] [PATCH] replace syscall_init
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 21/25] [PATCH] export cpu_gdt_descr
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 22/25] [PATCH] turn priviled operation into a macro
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 23/25] [PATCH] paravirt hooks for arch initialization
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 24/25] [PATCH] provide paravirt patching function
- From: Glauber de Oliveira Costa <[email protected]>
- [PATCH 25/25] [PATCH] add paravirtualization support for x86_64
- From: Glauber de Oliveira Costa <[email protected]>
- Re: [PATCH 25/25] [PATCH] add paravirtualization support for x86_64
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [PATCH 25/25] [PATCH] add paravirtualization support for x86_64
- From: "Glauber de Oliveira Costa" <[email protected]>
- Introducing paravirt_ops for x86_64
- Prev by Date: Re: [PATCH 0/1] lro: Generic Large Receive Offload for TCP traffic
- Next by Date: Re: [PATCH 00/23] per device dirty throttling -v8
- Previous by thread: Re: [PATCH 25/25] [PATCH] add paravirtualization support for x86_64
- Next by thread: Re: [PATCH 25/25] [PATCH] add paravirtualization support for x86_64
- Index(es):
 |