Question: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :

1) * Possible wasted stats overhead during dequeue..
sched_rt.c: 
Is RT check needed within a RT func? 
dequeue_task_rt() calls update_curr_rt() 
which checks for priority of RR or FIFO.

WITHIN..
static inline void update_curr_rt(struct rq *rq)

are the two lines..
if (!task_has_rt_policy(curr))
    return;

Generally if I am reading this right, then what
 RT task is neither FIFO or RR???

Thus, I think those two lines could be removed.

2) nit....
The comment within sched_rt.c
----->   Adding/removing a task to/from a priority array:
Is placed before dequeue_task_rt() where
enqueue_task_rt() is placed above the comment

Thus, the comment should be moved above enqueue_task_rt()

Mitchell Erblich




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Question: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :
    • From: "Dmitry Adamushko" <[email protected]>

• Prev by Date: Re: [PATCH] Remove x86_cpu_to_log_apicid
• Next by Date: [PATCH 5/5 -v2] Move the lguest files that are i386 specific
• Previous by thread: linux USB Device.
• Next by thread: Re: Question: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]