Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

Hello,

Eric W. Biederman wrote:
>> More specifically, d_off field.  It's a bit twisted.  For the last
>> entry, filp->f_pos gets written into the field and gets wrapped while
>> being copied out to userland or in glibc.
> 
> That could do it, and glibc is crunching it.  Oh well, it is
> easy enough to avoid as long as our inode numbers are small which
> the idr allocator seems to ensure.

Yeah, now I think about it.  glibc throws out entries which don't fit in
the data structure specified by the called API, so it probably threw out
the last entry which has UINT_MAX in d_off which doesn't fit in the
readdir() return structure.  Using INT_MAX should be just fine as IDA
always allocates the first empty slot.  We can add paranoia check in ino
allocation path.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH 5/5] sysfs: make sysfs_addrm_finish() return void
    • From: Tejun Heo <[email protected]>
  • [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Tejun Heo <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Tejun Heo <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Tejun Heo <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Tejun Heo <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: PAT support for i386 and x86_64
• Next by Date: [PATCH] Make UIO available for arm architecture
• Previous by thread: Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
• Next by thread: Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]