Re: [PATCH 0/25] Sysfs cleanups & tagged directory support

Eric W. Biederman wrote:
> Tejun Heo <[email protected]> writes:
> 
>> Cornelia Huck wrote:
>>> On Wed, 08 Aug 2007 23:35:36 +0900,
>>> Tejun Heo <[email protected]> wrote:
>>>
>>>> Does the attached patch happen to fix the problem?
>>> Indeed it does; thanks!
>> Yeah, you seem to have 32bit off_t.  UINT_MAX overflows, so...
> 
> Weird.  And we have it opening the directory O_LARGEFILE.
> 
> I have no problems with the fix though.

It's probably because of struct dirent definition used by readdir().  It
may differ depending on archs and glibc version but IIRC the backend
implementation of all directory listing functions in glibc were the
same.  It opens with O_LARGEFILE and use getdents64 to get full info
then clip it to whatever limit the called API imposes.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Tejun Heo <[email protected]>

• References:
  • [PATCH 5/5] sysfs: make sysfs_addrm_finish() return void
    • From: Tejun Heo <[email protected]>
  • [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Tejun Heo <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Cornelia Huck <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: Tejun Heo <[email protected]>
  • Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: [PATCH] Add ability to print calltraces tighter on i386
• Next by Date: Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
• Previous by thread: Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
• Next by thread: Re: [PATCH 0/25] Sysfs cleanups & tagged directory support
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]