On Tue, 7 Aug 2007 21:51:49 +0100
Christoph Hellwig <[email protected]> wrote:
> > +void attr_kill_to_mode(struct inode *inode, struct iattr *attr)
>
> This function badly needs a kerneldoc description. Also I can't say
> I like the name a lot, but without a clearly better idea I should
> probably not complain :)
>
Thanks for the comments.
I'm not thrilled with the name either, but kill_suid and *remove_suid
were already taken, and I really didn't want to name this something too
similar since there are already so many similarly named functions that
don't do the same thing. I'm definitely open to suggestions for
something different.
> We should at least add a generic_ prefix to indicate it's a generic
> helper valid for most filesystem (and the kerneldoc comment can explain
> the details)
>
Both good suggestions. I'll plan to incorporate them in the next
respin of the set.
Thanks,
--
Jeff Layton <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
