Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

> +void attr_kill_to_mode(struct inode *inode, struct iattr *attr)

This function badly needs a kerneldoc description.  Also I can't say
I like the name a lot, but without a clearly better idea I should
probably not complain :)

We should at least add a generic_ prefix to indicate it's a generic
helper valid for most filesystem (and the kerneldoc comment can explain
the details)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
  - From: Jeff Layton <[email protected]>

References:
- [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
  - From: Jeff Layton <[email protected]>

Prev by Date: [2.6.22.2 review 33/84] splice: fix double page unlock
Next by Date: [2.6.22.2 review 34/84] drm/i915: Fix i965 secured batchbuffer usage (CVE-2007-3851)
Previous by thread: Re: [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
Next by thread: Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]