Re: [patch] implement smarter atime updates support

O> you might want to add
> 
> 	/* 
> 	 * if the inode is dirty already, do the atime update since
> 	 * we'll be doing the disk IO anyway to clean the inode.
> 	 */
> 	if (inode->i_state & I_DIRTY)
> 		return 1;

This makes the actual result somewhat less predictable. Is that wise ?
Right now its clear what happens based on what user sequence of events
and that this is easily repeatable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] implement smarter atime updates support
    • From: Arjan van de Ven <[email protected]>

• References:
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Jakob Oestergaard <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Jakob Oestergaard <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 00/23] per device dirty throttling -v8
    • From: Ingo Molnar <[email protected]>
  • [patch] implement smarter atime updates support
    • From: Ingo Molnar <[email protected]>
  • Re: [patch] implement smarter atime updates support
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: [PATCH] sonypi: Fix initialization warning
• Next by Date: Re: high system cpu load during intense disk i/o
• Previous by thread: Re: [patch] implement smarter atime updates support
• Next by thread: Re: [patch] implement smarter atime updates support
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]