On Tue, 2007-07-31 at 15:34 -0700, Andrew Morton wrote: > On Tue, 31 Jul 2007 15:25:11 -0700 > Badari Pulavarty <[email protected]> wrote: > > > + dio->map_bh.b_state = 0; > > ho hum, thanks. > > We zero out so many fields in there now that a kzalloc() might yield > a net gain. 0.000001% in an unnamed benchmark! Yep. I think its worth doing a kzalloc(). I wanted to understand the *actual* problem to make sure we are addressing it, rather than kzalloc() made it disappear. Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: [PATCH] add check do_direct_IO() return val
- From: Joe Jin <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: gurudas pai <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Joe Jin <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Andrew Morton <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Badari Pulavarty <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Zach Brown <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Badari Pulavarty <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Zach Brown <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Joe Jin <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Badari <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Joe Jin <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Badari Pulavarty <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- From: Andrew Morton <[email protected]>
- Re: [PATCH] add check do_direct_IO() return val
- Prev by Date: Re: [PATCH] add check do_direct_IO() return val
- Next by Date: Re: "Add support for vector domain" breaks boot on x355
- Previous by thread: Re: [PATCH] add check do_direct_IO() return val
- Next by thread: Re: [PATCH] add check do_direct_IO() return val
- Index(es):
 |