Re: [PATCH] add check do_direct_IO() return val

On Sat, 28 Jul 2007 11:47:19 +0800
Joe Jin <[email protected]> wrote:

> > I tested Andrew's patch and panic was gone but got few ENOTBLK.
> > So I tried with Joe's patch , both panic and ENOTBLK are gone now.
> > But in Joe's patch if (ret == -ENOTBLK && (rw & WRITE)), dio_cleanup(dio)
> > was not getting called because of break. So I moved dio_cleanup just 
> > after if (ret).
> 
> Guru, actually, break from the loop with ENOTBLK will call dio_cleanup
> at leater, if call it too early, that means will put_page(), maybe cause
> other panic.
> 

fyi, I dropped the earlier patch and now we have nothing.  Please let's get all
this sorted out in time for 2.6.23.  Which is still many weeks away so there is
plenty of time to prepare something which was carefully reviewed and well-tested,
thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] add check do_direct_IO() return val
    • From: Badari Pulavarty <[email protected]>
  • Re: [PATCH] add check do_direct_IO() return val
    • From: Zach Brown <[email protected]>

• References:
  • [PATCH] add check do_direct_IO() return val
    • From: Joe Jin <[email protected]>
  • Re: [PATCH] add check do_direct_IO() return val
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] add check do_direct_IO() return val
    • From: Joe Jin <[email protected]>
  • Re: [PATCH] add check do_direct_IO() return val
    • From: gurudas pai <[email protected]>
  • Re: [PATCH] add check do_direct_IO() return val
    • From: Joe Jin <[email protected]>

• Prev by Date: Re: [PATCH 2/2] Wait for page writeback when directly reclaiming contiguous areas
• Next by Date: Re: [ck] Re: SD still better than CFS for 3d ?(was Re: 2.6.23-rc1)
• Previous by thread: Re: [PATCH] add check do_direct_IO() return val
• Next by thread: Re: [PATCH] add check do_direct_IO() return val
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]