Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver

On Tue, 31 Jul 2007 01:44:37 +0530 (IST) Satyam Sharma wrote:

> 
> 
> On Mon, 30 Jul 2007, John W. Linville wrote:
> 
> > On Mon, Jul 30, 2007 at 12:50:31PM +0530, Satyam Sharma wrote:
> > > On Mon, 30 Jul 2007, Matthias Kaehlcke wrote:
> > > 
> > > > [...]
> > > > The Host AP driver uses a semaphore as mutex. Use the mutex API
> > > > instead of the (binary) semaphore.
> > > > 
> > > > Signed-off-by: Matthias Kaehlcke <[email protected]>
> > > 
> > > Reviewed-by: Satyam Sharma <[email protected]>
> > 
> > Is that the same as Acked-by?  Or do you disagree with the patch?
> > 
> > Just checkin'...
> 
> Well, I'm not the maintainer, so didn't think correct to give an
> "Acked-by". "Reviewed-by" generally means I read the patch, and think
> it is correct. Probably could save time for others ...

You should use Acked-by.  See Documentation/SubmittingPatches.  :)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/5] use mutex instead of semaphore in several drivers
    • From: Matthias Kaehlcke <[email protected]>
  • [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Matthias Kaehlcke <[email protected]>
  • Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Michael Buesch <[email protected]>
  • Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Satyam Sharma <[email protected]>
  • Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Satyam Sharma <[email protected]>
  • Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Matthias Kaehlcke <[email protected]>
  • Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Satyam Sharma <[email protected]>
  • Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: "John W. Linville" <[email protected]>
  • Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Satyam Sharma <[email protected]>

• Prev by Date: Re: [patch] sched: yield debugging
• Next by Date: Re: bonnie++ benchmarks for ext2,ext3,ext4,jfs,reiserfs,xfs,zfs on software raid 5
• Previous by thread: Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
• Next by thread: Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]