Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver

On Sunday 29 July 2007 23:34, Matthias Kaehlcke wrote:
> The Host AP driver uses a semaphore as mutex. Use the mutex API
> instead of the (binary) semaphore.
> 
> Signed-off-by: Matthias Kaehlcke <[email protected]>
> 
> --
> 
> -	res = down_interruptible(&local->rid_bap_sem);
> +	res = mutex_lock_interruptible(&local->rid_bap_mtx);
>  	if (res)
>  		return res;
>  
> @@ -902,7 +902,7 @@ static int hfa384x_set_rid(struct net_device *dev, u16 rid, void *buf, int len)
>  	/* RID len in words and +1 for rec.rid */
>  	rec.len = cpu_to_le16(len / 2 + len % 2 + 1);
>  
> -	res = down_interruptible(&local->rid_bap_sem);
> +	res = mutex_lock_interruptible(&local->rid_bap_mtx);
>  	if (res)
>  		return res;
>  

Is res returned to userspace? If yes, that's not right.
On a interrupted mutex allocation you should return
-ERESTARTSYS to userspace.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Satyam Sharma <[email protected]>

• References:
  • [PATCH 0/5] use mutex instead of semaphore in several drivers
    • From: Matthias Kaehlcke <[email protected]>
  • [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
    • From: Matthias Kaehlcke <[email protected]>

• Prev by Date: Re: Power Management framework proposal
• Next by Date: Re: [PATCH 2/2] Introduce CONFIG_SUSPEND
• Previous by thread: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
• Next by thread: Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]