Re: [patch] x86, serial: always probe for legacy COM ports

[Jeff Garzik <jeff@garzik.org>]

Bjorn Helgaas wrote:
> On Friday 27 July 2007 02:21:55 pm Jeff Garzik wrote:
> > Bjorn Helgaas wrote:
> > > On Friday 27 July 2007 12:05:51 pm Jeff Garzik wrote:
> > > > This is still incomplete, as repeatedly stated.  Here is the email, again.

> > > OK, uncle!  I'll work on your helpful advice (thanks for that), but
> > > it feels too risky for this stage of 2.6.23.  Maybe I can come up with
> > > something for a future release.

> > The changeset in the kernel is too risky _without_ the changes I described.
>
> That's what I meant.  Andrew already has a revert patch in -mm, and
> the safest path seems like putting the reversion in 2.6.23 and working
> on your advice post-2.6.23.

Ah, my apologies!

I read "I'll work on your advice, but it feels too risky" as describing 
my advice as too risky, rather than the changeset currently in the kernel.

IMO the changeset should be resubmitted as two changes, separating the 
probe behavior changes from the platform driver conversion.  They are 
two distinct changes, and that would allow git-bisect to identify the 
culprit easily if future breakage occurs.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/