Benjamin Herrenschmidt wrote:
On Tue, 2007-07-24 at 17:55 -0400, Trond Myklebust wrote:If you want to use bitops as spinlocks you should rather be using <linux/bit_spinlock.h>. That also does the right thing w.r.t. pre-emption and sparse locking annotations.Heh, I didn't know about those... A bit annoying that I can't override them in the arch, I might be able to save a barrier or two here. Our
I guess the test_and_set_bit_lock / clear_bit_unlock will allow you to override them in a way. The big performance problem I see on my powerpc system is not the bit spinlocks (open-coded or not), but the bit sleep locks. Anyway, I'll finally send out the lock bitops patches again today... -- SUSE Labs, Novell Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize
- From: Satyam Sharma <[email protected]>
- [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Satyam Sharma <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Trond Myklebust <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Trond Myklebust <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Benjamin Herrenschmidt <[email protected]>
- [PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize
- Prev by Date: Re: -mm merge plans for 2.6.23
- Next by Date: Re: [RFC] fs/super.c: Why alloc_super use a static variable default_op?
- Previous by thread: Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- Next by thread: Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- Index(es):
 |