On Tue, 2007-07-24 at 17:55 -0400, Trond Myklebust wrote: > > If you want to use bitops as spinlocks you should rather be using > <linux/bit_spinlock.h>. That also does the right thing w.r.t. > pre-emption and sparse locking annotations. Heh, I didn't know about those... A bit annoying that I can't override them in the arch, I might be able to save a barrier or two here. Our test_and_set_bit() contains both barriers for lock and unlock semantics to cope with all kind of abuses, but your bit_spinlock obviously doesn't need that. Cheers, Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- [PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize
- From: Satyam Sharma <[email protected]>
- [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Satyam Sharma <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Trond Myklebust <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- From: Trond Myklebust <[email protected]>
- [PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize
- Prev by Date: Re: [Lksctp-developers] __unsafe() usage
- Next by Date: Re: [PATCH 1/7] lguest: documentation pt I: Preparation
- Previous by thread: Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- Next by thread: Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
- Index(es):
 |