Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

On Mon, Jul 23, 2007 at 08:52:41PM -0700, Andrew Morton wrote:
> On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <[email protected]> wrote:
> 
> > -	ra->prev_index = page->index;
> > +	ra->prev_pos = page->index << PAGE_CACHE_SHIFT;
> 
> bug!  The rhs will get truncated befire it gets assigned to
> the lhs.  Need to cast page->index to loff_t.
> 
> I'll fix this one up.  Please review the other patches for this?

Thank you. Be sure to update *all* the lines:
        ra->prev_pos = page->index << PAGE_CACHE_SHIFT

Other places should have been taken care of.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos
    • From: Fengguang Wu <[email protected]>
  • Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily
• Next by Date: [PATCH] Doc/sysfs-rules typos
• Previous by thread: Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos
• Next by thread: Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]