Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <[email protected]> wrote:

> -	ra->prev_index = page->index;
> +	ra->prev_pos = page->index << PAGE_CACHE_SHIFT;

bug!  The rhs will get truncated befire it gets assigned to
the lhs.  Need to cast page->index to loff_t.

I'll fix this one up.  Please review the other patches for this?


I decided to merge this ahead of that great pile of Nick's patches
(pagecache write deadlocks) and gto a number of easy-to-fix rejects as a
result.  Hopefully it all landed OK.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos
    • From: Fengguang Wu <[email protected]>

• References:
  • [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos
    • From: Fengguang Wu <[email protected]>

• Prev by Date: Re: 2.6.22-git17 boot failure
• Next by Date: Re: [PATCH 8/8] i386: bitops: smp_mb__{before, after}_clear_bit() definitions
• Previous by thread: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos
• Next by thread: Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]