Re: [PATCH] Check for compound pages in set_page_dirty()

On Thu, 19 Jul 2007 18:35:17 +0100 (BST)
Hugh Dickins <[email protected]> wrote:

> I didn't see any attention to set_page_dirty in Christoph's
> Large Blocksize (variable page_cachesize) patches, but I expect
> he'd also be wanting set_page_dirty to act on compound_head.

There is no need for special casing if set_page_dirty() is only
ever called for page heads. Make sure that direct I/O does not call
set_page_dirty for tail pages.

A VM_BUG_ON(PageTail(page)) could be used to make sure that this
does not happen in the future?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Check for compound pages in set_page_dirty()
    • From: Hugh Dickins <[email protected]>

• References:
  • [PATCH] Check for compound pages in set_page_dirty()
    • From: Jens Axboe <[email protected]>
  • Re: [PATCH] Check for compound pages in set_page_dirty()
    • From: Hugh Dickins <[email protected]>
  • Re: [PATCH] Check for compound pages in set_page_dirty()
    • From: Jens Axboe <[email protected]>
  • Re: [PATCH] Check for compound pages in set_page_dirty()
    • From: Jens Axboe <[email protected]>
  • Re: [PATCH] Check for compound pages in set_page_dirty()
    • From: Hugh Dickins <[email protected]>
  • Re: [PATCH] Check for compound pages in set_page_dirty()
    • From: Jens Axboe <[email protected]>
  • Re: [PATCH] Check for compound pages in set_page_dirty()
    • From: Hugh Dickins <[email protected]>

• Prev by Date: Re: [linux-usb-devel] 2.6.22+: BUG: sleeping function called from invalid context at /home/jeremy/hg/xen/paravirt/linux/drivers/usb/core/urb.c:524, in_atomic():1, irqs_disabled():0
• Next by Date: Re: early_printk accessing __log_buf
• Previous by thread: Re: [PATCH] Check for compound pages in set_page_dirty()
• Next by thread: Re: [PATCH] Check for compound pages in set_page_dirty()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]