Re: [PATCH] Check for compound pages in set_page_dirty()

On Thu, Jul 19, 2007 at 06:35:17PM +0100, Hugh Dickins wrote:
> I started from your patch.  But it now seems to me a bugfix to remove
> those PageCompound tests, because they're preventing a hugetlb page
> from being marked dirty, when Ken needs it to be marked dirty so
> /proc/sys/vm/drop_caches doesn't drop the data read in by DIO.
> (His original patch went into -stable: would the patch fixing
> this all up need to go into -stable?)

This needs to be done some other way. The dirty bit should not be
significant for pseudofs's with no backing store. The consequences
of making it so are becoming apparent in the IO path, and it
caused performance regressions elsewhere as well. ramfs, for instance,
doesn't require anything of this sort to cope with drop_caches.

-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] Check for compound pages in set_page_dirty()
  - From: Jens Axboe <[email protected]>
- Re: [PATCH] Check for compound pages in set_page_dirty()
  - From: Hugh Dickins <[email protected]>
- Re: [PATCH] Check for compound pages in set_page_dirty()
  - From: Jens Axboe <[email protected]>
- Re: [PATCH] Check for compound pages in set_page_dirty()
  - From: Jens Axboe <[email protected]>
- Re: [PATCH] Check for compound pages in set_page_dirty()
  - From: Hugh Dickins <[email protected]>
- Re: [PATCH] Check for compound pages in set_page_dirty()
  - From: Jens Axboe <[email protected]>
- Re: [PATCH] Check for compound pages in set_page_dirty()
  - From: Hugh Dickins <[email protected]>

Prev by Date: Re: [patch] slub crashes with recent -git
Next by Date: Re: [PATCH] Remove unneded lock_kernel() in driver/block/loop.c
Previous by thread: Re: [PATCH] Check for compound pages in set_page_dirty()
Next by thread: Re: [PATCH] Check for compound pages in set_page_dirty()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]