Re: [PATCH] fix theoretical ccids_{read,write}_lock() race

On Sat, 21 Jul 2007 19:02:06 +0400 Oleg Nesterov <[email protected]> wrote:

> Make sure that spin_unlock_wait() is properly ordered wrt atomic_inc().
> 
> Signed-off-by: Oleg Nesterov <[email protected]>
> 
> --- t/net/dccp/ccid.c~ccid	2006-12-18 18:17:31.000000000 +0300
> +++ t/net/dccp/ccid.c	2007-07-21 18:29:21.000000000 +0400
> @@ -40,6 +40,7 @@ static inline void ccids_write_unlock(vo
>  static inline void ccids_read_lock(void)
>  {
>  	atomic_inc(&ccids_lockct);
> +	smp_mb__after_atomic_inc();
>  	spin_unlock_wait(&ccids_lock);
>  }
>  

Why not just use standard rwlocks in there?

(This is probably an FAQ, but it should be).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix theoretical ccids_{read,write}_lock() race
    • From: Oleg Nesterov <[email protected]>

• References:
  • [PATCH] pi-futex: set PF_EXITING without taking ->pi_lock
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] pi-futex: set PF_EXITING without taking ->pi_lock
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH] pi-futex: set PF_EXITING without taking ->pi_lock
    • From: Oleg Nesterov <[email protected]>
  • [PATCH] fix theoretical ccids_{read,write}_lock() race
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: [PATCH 0/3] readahead drop behind and size adjustment
• Next by Date: Re: [PATCH] Use menuconfig objects - Fusion
• Previous by thread: [PATCH] fix theoretical ccids_{read,write}_lock() race
• Next by thread: Re: [PATCH] fix theoretical ccids_{read,write}_lock() race
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]