[PATCH] fix theoretical ccids_{read,write}_lock() race

Make sure that spin_unlock_wait() is properly ordered wrt atomic_inc().

Signed-off-by: Oleg Nesterov <[email protected]>

--- t/net/dccp/ccid.c~ccid	2006-12-18 18:17:31.000000000 +0300
+++ t/net/dccp/ccid.c	2007-07-21 18:29:21.000000000 +0400
@@ -40,6 +40,7 @@ static inline void ccids_write_unlock(vo
 static inline void ccids_read_lock(void)
 {
 	atomic_inc(&ccids_lockct);
+	smp_mb__after_atomic_inc();
 	spin_unlock_wait(&ccids_lock);
 }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] fix theoretical ccids_{read,write}_lock() race
  - From: Andrew Morton <[email protected]>

References:
- [PATCH] pi-futex: set PF_EXITING without taking ->pi_lock
  - From: Oleg Nesterov <[email protected]>
- Re: [PATCH] pi-futex: set PF_EXITING without taking ->pi_lock
  - From: Ingo Molnar <[email protected]>
- Re: [PATCH] pi-futex: set PF_EXITING without taking ->pi_lock
  - From: Oleg Nesterov <[email protected]>

Prev by Date: [PATCH 3/4] [msr driver] Simplify smp_call_function_single() call sequence
Next by Date: [00/37] Clean up duplicate includes
Previous by thread: Re: [PATCH] pi-futex: set PF_EXITING without taking ->pi_lock
Next by thread: Re: [PATCH] fix theoretical ccids_{read,write}_lock() race
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]