Re: pata_platform: Fix NULL pointer dereference

[Jan Engelhardt <jengelh@computergmbh.de>]

On Jul 20 2007 09:12, Linus Torvalds wrote:
>Ok, the *fix* looks real enough, but it seems that you have done your line 
>splitting with a word processor rather than with a source code editor:
>
>> +	return ata_host_activate(host, platform_get_irq(pdev, 0),
>> +				 ata_interrupt, pp_info ? pp_info->irq_flags
>> +				 : 0, &pata_platform_sht);
>
>Please don't do things like this. Splitting up expressions across two 
>lines just to make the line length come out "right" is silly.
>
>So do the
>
>	"pp_info ? pp_info->irq_flags : 0"
>
>expression on one line.

Or just do

	return ata_host_activate(host, platform_get_irq(pdev, 0),
	       ata_interrupt, pp_info ? pp_info->irq_flags : 0,
	       &pata_platform_sht);

for returns, it's ok.


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/