On Fri, 20 Jul 2007, Magnus Damm wrote:
>
> pata_platform currently dereferences a NULL pointer in pata_platform_probe()
> if pdev->dev.platform_data is set to NULL. This breakage was most likely
> introduced by commit 5f45bc50976ee1f408f7171af155aec646655a37.
Ok, the *fix* looks real enough, but it seems that you have done your line
splitting with a word processor rather than with a source code editor:
> + return ata_host_activate(host, platform_get_irq(pdev, 0),
> + ata_interrupt, pp_info ? pp_info->irq_flags
> + : 0, &pata_platform_sht);
Please don't do things like this. Splitting up expressions across two
lines just to make the line length come out "right" is silly.
So do the
"pp_info ? pp_info->irq_flags : 0"
expression on one line.
And if it means that the line is longe rthan 80 characters, then so be it.
It's ok. It's still more readable than the alternative.
Linus "nit-picking bastard" Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
