On 7/20/07, rae l <[email protected]> wrote:
On 7/20/07, Dave Young <[email protected]> wrote:
> > - if (page && zeroing && count < PAGE_SIZE) {
> > - void *mapaddr = kmap_atomic(page, KM_USER1);
> > - memset(mapaddr, 0, PAGE_SIZE);
> > - kunmap_atomic(mapaddr, KM_USER1);
> > - }
> > + if (page && zeroing && count < PAGE_SIZE)
> > + zero_user_page(page, 0, PAGE_SIZE, KM_USER1);
> Why clear all page? IMHO,only count bytes need to be cleared.
The original one is memset(mapaddr, 0, PAGE_SIZE), namely clear the whole page.
Yes, I have same suspicion with original code.
--
Denis Cheng
Linux Application Developer
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
