Ingo Molnar wrote:
> no, the return value after idling can be completely random on some
> boxes, on a 64-bit scale - triggering the softlockup watchdog randomly.
> (some boxes return random TSC values, etc.) Again, it's fine for the
> scheduler's purpose, that's why i named it sched_clock().
>
> the proper clocksource use within the kernel is ktime_get() [or
> ktime_get_ts()]. Do not abuse sched_clock() for such things.
Well, my observation is that both softlockup and the scheduler really
want to measure unstolen time, so it seemed to me that sched_clock was a
nice common place to implement that, rather than implementing a whole
new time interface. At the time that seemed OK, and nobody had any
objections.
But it's a bit beside the point unless it does turn out to be making
Andrew's Vaio sad.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch] fix the softlockup watchdog to actually work
- From: Ingo Molnar <[email protected]>
- Re: [patch] fix the softlockup watchdog to actually work
- References:
- [patch] softlockup watchdog: fix Xen bogosity
- From: Ingo Molnar <[email protected]>
- Re: [patch] softlockup watchdog: fix Xen bogosity
- From: Jeremy Fitzhardinge <[email protected]>
- [patch] fix the softlockup watchdog to actually work
- From: Ingo Molnar <[email protected]>
- Re: [patch] fix the softlockup watchdog to actually work
- From: Andrew Morton <[email protected]>
- Re: [patch] fix the softlockup watchdog to actually work
- From: Ingo Molnar <[email protected]>
- Re: [patch] fix the softlockup watchdog to actually work
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [patch] fix the softlockup watchdog to actually work
- From: Ingo Molnar <[email protected]>
- Re: [patch] fix the softlockup watchdog to actually work
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [patch] fix the softlockup watchdog to actually work
- From: Ingo Molnar <[email protected]>
- [patch] softlockup watchdog: fix Xen bogosity
- Prev by Date: Re: [PATCH for review] [11/48] x86_64: During VM oom condition, kill all threads in process group
- Next by Date: Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll
- Previous by thread: Re: [patch] fix the softlockup watchdog to actually work
- Next by thread: Re: [patch] fix the softlockup watchdog to actually work
- Index(es):
 |