On Thu, Jul 19, 2007 at 09:27:41AM +1000, Rusty Russell wrote:
> On Wed, 2007-07-18 at 09:19 -0700, Zachary Amsden wrote:
> > > +#define GET_CONTENTS(desc) (((desc)->raw32.b >> 10) & 3)
> > > +#define GET_WRITABLE(desc) (((desc)->raw32.b >> 9) & 1)
> >
> > You got rid of the duplicate definitions here, but then added new
> > duplicates (GET_CONTENTS / WRITABLE). Can you stick them in desc.h?
>
> To be honest, I got sick of counting bits at this point, and didn't want
> to introduce bugs.
Where is 1/ and 3/ ?
I got an older version of this patch queued now
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
