Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Wednesday 18 July 2007, Jens Axboe wrote:
> On Wed, Jul 18 2007, Linus Torvalds wrote:
> > 
> > 
> > On Wed, 18 Jul 2007, Jens Axboe wrote:
> > > 
> > > I think your analysis is pretty good, however you'd probably want to
> > > incorporate that direct in ide_end_request().
> > 
> > Ok, that makes sense too.
> > 
> > And yes, the further cleanup would be:
> > 
> > > Better still would be to make __ide_end_request() take a byte count
> > > instead and use end_that_request_chunk(). Then you can get rid of the
> > > rounding as well.
> > 
> > and that sounds fine, but is an independent issue and not strictly 
> > necessary.
> 
> Oh yeah, it's just a further improvement, not strictly necessary for
> fixing this bug. So it could be done at a later time, all up to Bart...

Thanks for finding and fixing this.

The latest patch (with additional cleanups) also looks good and should be
safe enough (unchanged behavior for all non-pc requests) to merge it now.

Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/