Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:

On Wed, 18 Jul 2007, Jens Axboe wrote:
> 
> I think your analysis is pretty good, however you'd probably want to
> incorporate that direct in ide_end_request().

Ok, that makes sense too.

And yes, the further cleanup would be:

> Better still would be to make __ide_end_request() take a byte count
> instead and use end_that_request_chunk(). Then you can get rid of the
> rounding as well.

and that sounds fine, but is an independent issue and not strictly 
necessary.

Bartlomiej?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:
    • From: Jens Axboe <[email protected]>

• References:
  • regression: disk error loop (panic?) ide_do_rw_disk-bad:
    • From: Giacomo Catenazzi <[email protected]>
  • Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:
    • From: Bartlomiej Zolnierkiewicz <[email protected]>
  • Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:
    • From: Linus Torvalds <[email protected]>
  • Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:
    • From: Jens Axboe <[email protected]>

• Prev by Date: Re: sysfs root link count broken in 2.6.22-git5
• Next by Date: Re: [PATCH] isdn/sc: compile breakage re check_reset()
• Previous by thread: Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:
• Next by thread: Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]