Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/18/07, Tejun Heo <[email protected]> wrote:
Satyam Sharma wrote:
> Readability, fewer LOC, 308 lesser bytes in kernel image and
> faster for the common case -- not good enough for you?! Oh, well.

Sorry, not agreed on readability.  The rest doesn't really matter too
much and please stop making big deal out of this kind of stuff.  Things
like that do matter but not that much.  Mostly it's matter of getting
used to and there are many alternatives.  Some people like things one
way other people like another.  My taste might not be the best around
here but I don't think it's that awful either.  You may find my taste
disgusting but we all have to deal with such issue, don't we?

Whoops, I didn't mean to get confrontational, and certainly didn't
make any remarks on your taste/etc personally. Just felt that the
present code looked obfuscated, and submitted a cleanup -- the
other things just turned out to be happy side-effects.

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux