Re: [PATCH 2/2] net/core: some functions' definition order adjustment for readability

On 7/18/07, Patrick McHardy <[email protected]> wrote:

This could be done in the patch moving it .. anyways,

What?

Denis Cheng wrote:
> +#ifdef CONFIG_PROC_FS
> +static void *dev_mc_seq_start(struct seq_file *seq, loff_t *pos)


If you're interested in doing more work, it would be nice to
generalize the seq-file functions for unicast and multicast
address lists and add /proc/net/dev_unicast or something like
that.

Eh, there is already a dev_multicast file but lack of dev_unicast,
but is dev_unicast really useful?

OTOH we could also export this using rtnetlink. The main reason
why I didn't do that is that it can only be read, not changed,
but this is also true for statistics etc. Any opinions on this?

how to do that?

--
Denis Cheng
Linux Application Developer

"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
    • From: David Miller <[email protected]>
  • [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c
    • From: Denis Cheng <[email protected]>
  • [PATCH 2/2] net/core: some functions' definition order adjustment for readability
    • From: Denis Cheng <[email protected]>
  • Re: [PATCH 2/2] net/core: some functions' definition order adjustment for readability
    • From: Patrick McHardy <[email protected]>

• Prev by Date: [2.6.22.1] spurious (?) message "BUG: lock held at task exit time"
• Next by Date: Re: [patch 1/3] ps3: Disk Storage Driver
• Previous by thread: Re: [PATCH 2/2] net/core: some functions' definition order adjustment for readability
• Next by thread: Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]