Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c

From: "rae l" <[email protected]>
Date: Wed, 18 Jul 2007 17:59:52 +0800

> And then the dev_mcast.c is now only 256 lines long(versus dev.c 4052 lines),
> just left a few multicast related functions definition and "dev_mcast"
> procfs code,
> I have an idea to merge all code dev_mcast.c into dev.c, that would:
> 
> - remove two functions (__dev_addr_delete, __dev_set_rx_mode) from netdevice.h,
>   and then tag them static,
>   those two are also defined in dev.c and only called from dev_mcast.c,
> 
> - reducing one file would benefit the compilation process.
> 
> All in one word, I don't think the single file dev_mcast.c is needed anymore.

Agreed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c
  - From: Denis Cheng <[email protected]>

References:
- [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
  - From: Denis Cheng <[email protected]>
- Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
  - From: David Miller <[email protected]>
- Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
  - From: "rae l" <[email protected]>

Prev by Date: Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
Next by Date: Re: [PATCH 03/33] powerpc: Refuse to build 64-bit with GCC-4.2.0 and CONFIG_MODULES
Previous by thread: Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c
Next by thread: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]